Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failing hook leaves temp files in repo root #18

Closed
brandonjbjelland opened this issue May 20, 2018 · 1 comment
Closed

failing hook leaves temp files in repo root #18

brandonjbjelland opened this issue May 20, 2018 · 1 comment

Comments

@brandonjbjelland
Copy link

If temp files need to be a part of this hook, I'd suggest putting them in a standard tucked away temp file location on the system. Since you're using bash anyway, we can assume Windows isn't supported unless through WSL. Consider sticking temp files in /tmp/ and having some cleanup logic if the hook fails.

screen shot 2018-05-17 at 12 48 57 am

@antonbabenko
Copy link
Owner

This has been resolved by #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants