Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: jump broken in Nuxt by double quote #15

Merged
merged 1 commit into from
Jan 8, 2024
Merged

fix: jump broken in Nuxt by double quote #15

merged 1 commit into from
Jan 8, 2024

Conversation

ShenQingchuan
Copy link
Contributor

@ShenQingchuan ShenQingchuan commented Jan 8, 2024 •
edited
Loading

Description

Supplement fix for #13 because I found that in Vitesse the generated component.d.ts is using single quote on path string while Nuxt is double, so I need to make this regexp more robust.

@ShenQingchuan
Copy link
Contributor Author

ShenQingchuan commented Jan 8, 2024 •
edited
Loading

Should be able to fix #11

@antfu Would you please assign me the authority to manage this project if possible, and I'd like to track these kinds of issues~

@antfu antfu merged commit 4b79365 into antfu:main Jan 8, 2024
2 checks passed
@ShenQingchuan ShenQingchuan deleted the fix-nuxt-jump-broken-by-double-quote branch January 9, 2024 10:49
@ShenQingchuan ShenQingchuan mentioned this pull request Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShenQingchuan @antfu