feat(resolver): adds component resolver for VueUse components #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
reviewed
May 25, 2021
src/resolvers/vueuse.ts
Outdated
| * @link https://github.com/vueuse/vueuse | ||
| */ | ||
| export const VueUseComponentsResolver = (): ComponentResolver => (name: string) => { | ||
| if (name.toLowerCase().startsWith('use') || name.toLowerCase().startsWith('on')) |
There was a problem hiding this comment.
Suggested change
| if (name.toLowerCase().startsWith('use') || name.toLowerCase().startsWith('on')) | |
| if (/^(?:Use|On)[A-Z]/.test(name)) |
Tho I still thinking maybe we should read the indexes.json to have more accurate match.
There was a problem hiding this comment.
Oh yeah that would be a much better way I think. Any preferred way we should go about reading indexes.json?
There was a problem hiding this comment.
Maybe we should ship it along with the package
There was a problem hiding this comment.
This should do in 5.0.0-beta.3:
require('@vueuse/core/indexes.json')
antfu
changed the title
ascott18
pushed a commit
to ascott18/unplugin-vue-components
that referenced
this pull request
Mar 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a resolver for vueuse components.