Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf!: use estree-walker #425

Merged
merged 2 commits into from
Jun 18, 2022
Merged

perf!: use estree-walker #425

merged 2 commits into from
Jun 18, 2022

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Jun 17, 2022 •
edited
Loading

  • use estree-walker.

estree-walker is faster and simpler than @babel/traverse.

FYI: a simple benchmark in my plugin.

P.S. Please keep estree-walker 2.x, cause estree-walker@3 is a ESM-only package.

@sxzz sxzz requested a review from antfu as a code owner June 17, 2022 18:33
@antfu
Copy link
Member

antfu commented Jun 18, 2022

We could bundle it to keep it up-to-date

@sxzz
Copy link
Member Author

sxzz commented Jun 18, 2022

estree-walker is an optional peer dep. So, we should add it to dep of this project?

@sxzz
Copy link
Member Author

sxzz commented Jun 18, 2022

Done.

@antfu antfu merged commit 8c9b114 into main Jun 18, 2022
@antfu antfu deleted the refactor/estree-walker branch June 18, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu Awaiting requested review from antfu antfu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sxzz @antfu