Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eqeqeq rule deprecated option allow-null #61

Merged
merged 2 commits into from
Sep 8, 2021
Merged

fix: eqeqeq rule deprecated option allow-null #61

merged 2 commits into from
Sep 8, 2021

Conversation

nirtamir2
Copy link
Contributor

According to the eqeqeq rule docs - option allow-null is deprecated.

https://eslint.org/docs/rules/eqeqeq#allow-null

Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell ESLint to always enforce strict equality except when comparing with the null literal.

This PR fixes it to use the null option.

NOTICE: If you prefer, eqeqeq has also smart option instead of always but it behaves differently.

packages/basic/index.js Outdated Show resolved Hide resolved
@antfu
Copy link
Owner

antfu commented Sep 8, 2021

Let's go smart! Thanks!

@antfu antfu merged commit 92c3e62 into antfu:master Sep 8, 2021
@nirtamir2 nirtamir2 deleted the patch-1 branch September 8, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants