Handle exceptions in controller signals #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linh2931
reviewed
Oct 25, 2024
linh2931
approved these changes
Oct 25, 2024
greg7mdp
approved these changes
Oct 25, 2024
| @@ -159,10 +158,11 @@ class vote_processor_t { | |||
| } | |||
|
|
|||
| public: | |||
| explicit vote_processor_t(vote_signal_t& vote_signal, fetch_block_func_t&& get_block) | |||
| : vote_signal(vote_signal) | |||
| explicit vote_processor_t(emit_vote_signal_func_t&& emit_vote_signal, fetch_block_func_t&& get_block) | |||
There was a problem hiding this comment.
The two parameters are rvalues... we should probably std::move them.
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new integration test that thows in all controller signals. It verifies that non-
controller_emit_signal_exceptionexceptions are caught and dropped and thatcontroller_emit_signal_exceptionshuts down the node in a state where it can be restarted.test_control_pluginupdated with/v1/test_control/throw_onendpoint for allowing external triggers of exceptions on signals.Includes a fix for reverting
chain_headifaccepted_blockthrows. This caused nodeos not to be able to restart as thechain_headdid not match the chainbase state.Includes a fix for
applied_transactionthrowing and shutting down nodeos.Includes a fix for
vote_signalthrowing and shutting down nodeos.Looking for opinions on if this PR should be backported to
release/1.0Resolves #946