Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestHarness: Remove hardcoded version checks to support Leap v3.1 and below. #952

Merged
merged 14 commits into from
Oct 21, 2024

Conversation

greg7mdp
Copy link
Contributor

@greg7mdp greg7mdp commented Oct 18, 2024

Resolves #48

@greg7mdp greg7mdp linked an issue Oct 18, 2024 that may be closed by this pull request
@greg7mdp greg7mdp changed the title Remove hardcoded version checks to support Leap v3.1 and below. TestHarness: Remove hardcoded version checks to support Leap v3.1 and below. Oct 18, 2024
Copy link
Member

@spoonincode spoonincode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed one more instance of something old-version related,

if type(specificExtraNodeosArgs) is dict:
for args in specificExtraNodeosArgs.values():
if "--plugin eosio::history_api_plugin" in args:
argsArr.append("--is-nodeos-v2")
break

which gets plumbed through to
cfg.add_argument('--is-nodeos-v2', action='store_true', help='Toggles old nodeos compatibility', default=False)

and
if is_bios:
if self.args.is_nodeos_v2:
a(a(eosdcmd, '--plugin'), 'eosio::history_api_plugin')
a(a(eosdcmd, '--filter-on'), '"*"')
else:
a(a(eosdcmd, '--plugin'), 'eosio::trace_api_plugin')

I suspect these can be removed too, but I don't know enough about the test harness to be confident

@greg7mdp
Copy link
Contributor Author

I noticed one more instance of something old-version related,

From my reading of the code, I think this code is currently active for any Spring/Leap version, including Spring 1.0, so I feel the safa alternative is to let that code remain. I don't know enough to say whether adding this flag is useful or not though.

@heifner
Copy link
Member

heifner commented Oct 18, 2024

From my reading of the code, I think this code is currently active for any Spring/Leap version, including Spring 1.0, so I feel the safa alternative is to let that code remain. I don't know enough to say whether adding this flag is useful or not though.

The history_api_plugin does not exist in Spring. All references to it can be removed.

tests/TestHarness/Node.py Outdated Show resolved Hide resolved
@ericpassmore
Copy link
Contributor

Note:start
category: Tests
component: Internal
summary: Cleanup tests, removed tests for Leap 3.1 and below. Removed tests for history_api_plugin which does not exist in Spring.
Note:end

@greg7mdp greg7mdp requested a review from heifner October 21, 2024 18:53
@greg7mdp greg7mdp merged commit 35ee346 into main Oct 21, 2024
36 checks passed
@greg7mdp greg7mdp deleted the gh_48 branch October 21, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestHarness version roll back ambiguity
4 participants