-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TestHarness: Remove hardcoded version checks to support Leap v3.1 and below. #952
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed one more instance of something old-version related,
spring/tests/TestHarness/Cluster.py
Lines 468 to 472 in f881e8a
if type(specificExtraNodeosArgs) is dict: | |
for args in specificExtraNodeosArgs.values(): | |
if "--plugin eosio::history_api_plugin" in args: | |
argsArr.append("--is-nodeos-v2") | |
break |
which gets plumbed through to
spring/tests/TestHarness/launcher.py
Line 210 in f881e8a
cfg.add_argument('--is-nodeos-v2', action='store_true', help='Toggles old nodeos compatibility', default=False) |
and
spring/tests/TestHarness/launcher.py
Lines 583 to 588 in f881e8a
if is_bios: | |
if self.args.is_nodeos_v2: | |
a(a(eosdcmd, '--plugin'), 'eosio::history_api_plugin') | |
a(a(eosdcmd, '--filter-on'), '"*"') | |
else: | |
a(a(eosdcmd, '--plugin'), 'eosio::trace_api_plugin') |
I suspect these can be removed too, but I don't know enough about the test harness to be confident
From my reading of the code, I think this code is currently active for any Spring/Leap version, including Spring 1.0, so I feel the safa alternative is to let that code remain. I don't know enough to say whether adding this flag is useful or not though. |
The |
Note:start |
Resolves #48