Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove finality directories. #928

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Remove finality directories. #928

merged 3 commits into from
Oct 17, 2024

Conversation

greg7mdp
Copy link
Contributor

We had finality directories in libraries/chain and libraries/chain/include/eosio/chain, however these were inconsistently used and were not proven to be useful. This PR removes these subdirectories and moves the files one level up.

@greg7mdp greg7mdp requested review from heifner and linh2931 October 14, 2024 15:11
linh2931
linh2931 approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@linh2931 linh2931 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have strong feeling on if or not we should have a separate directory for finality. We do have a separate webassmbly under chain.

heifner
heifner approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@heifner heifner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't really see the point, but this is fine I guess.

@greg7mdp
Copy link
Contributor Author

@areg, what do you think?

@ericpassmore
Copy link
Contributor

Note:start
category: Chores
component: Internal
summary: Remove unused finality directories under libraries .
Note:end

@greg7mdp
Copy link
Contributor Author

Didn't get a very enthusiastic response to this PR.
I'm OK tabling it if someone prefers having the finality directories as today, if so just let me know.
Otherwise I'll probably merge it later this evening.

@greg7mdp greg7mdp merged commit c159fbd into main Oct 17, 2024
36 checks passed
@greg7mdp greg7mdp deleted the rm_finality_dir branch October 17, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heifner heifner heifner approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@greg7mdp @ericpassmore @heifner @linh2931