Simplify qc verification and avoid creating a new aggregating_qc class.
#915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
approved these changes
Oct 9, 2024
greg7mdp
changed the title
aggregating_qc class.aggregating_qc class.
linh2931
approved these changes
Oct 9, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #743.
This moves the
verify_qcAPI fromaggregating_qc_ttoqc_t.It also renames it to
verify, becauseqc.verify_qc(policies)seems a bit redundant.It also removes
verify_dual_finalizers_votesandvotes_same_atfrom the external API because these are internal implementation details.