-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.0.2] Add new testcase where finality advances on alternate branch with lesser lib #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note:start |
linh2931
approved these changes
Sep 18, 2024
heifner
requested changes
Sep 18, 2024
heifner
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a testcase where finalizers cannot vote on a block from a different branch because they are locked on a block from their own branch.
After voting on
B5
(which makesB3
final), the finalizers who voted onB5
are locked onB4
, and therefore cannot vote onB6
:B6' s core.latest_qc_block_timestamp() < fsi.lock.timestamp
becauseB2 timestamp < B4 timestamp
.B6
does not extendB4
.As a result, this testcase reproduces the scenario described above, and verifies that we lack votes to form a QC on
B6
.Although until issue #778 is addressed, the problem described in issue #778 is the cause of the lack of votes, and
decide_vote
is not even called.