remove EOS VM OC workaround for LLVM 7.0.x ABI mixup #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
approved these changes
Sep 12, 2024
heifner
approved these changes
Sep 12, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove an old workaround for LLVM 7.0.x that resolved run time crashes due to ABI breakage inside of LLVM when spring was compiled with clang and LLVM was compiled with gcc.
This workaround was useful in the EOSIO 2.0 era because of RHEL7 support: the only official-ish package for an LLVM version compatible with EOSIO 2.0 was from SCL with just LLVM 7.0.1 (as a 'system' package of course this was compiled with gcc). But during this era of EOSIO we would often recommend building EOSIO was clang. Thus.. runtime breakage would occur in this configuration without the workaround.
We can remove this old workaround now.