Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move verify_qc onto the chain thread pool #736

Merged
merged 13 commits into from
Sep 12, 2024
Merged

Conversation

heifner
Copy link
Member

@heifner heifner commented Sep 10, 2024

During syncing one net thread was at 100% CPU. Moving the verify_qc onto the chain-threads thread pool gives about 10% CPU on a net thread and 50% on two chain-threads. Did not do detailed timing, but sync time improvement on my machine for 1000 block sync from ~ 3.5 seconds to ~3 seconds.

Creates the block_state and verifies producer signature on the net thread while the qc is being verified in the chain thread pool.

@heifner heifner added the OCI Work exclusive to OCI team label Sep 10, 2024
@ericpassmore ericpassmore added the enhancement New feature or request label Sep 10, 2024
@ericpassmore
Copy link
Contributor

Note:start
category: Other
component: Internal
summary: Increase capacity during heavy sync by moving verify_qc onto the chain thread pool.
Note:end

@heifner heifner marked this pull request as ready for review September 12, 2024 14:02
@heifner heifner added this to the Spring v1.1.0-rc1 milestone Sep 12, 2024
@heifner heifner merged commit 897b241 into main Sep 12, 2024
36 checks passed
@heifner heifner deleted the verify-qc-thread-pool branch September 12, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants