Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0-beta4 -> main] P2P: Fix fork check on connection #468

Merged
merged 6 commits into from
Aug 2, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Aug 2, 2024

If running without a block log or with a truncated block log, it is possible that trying to retrieve a block by number will fail because the block is not available in the block log. Modify on-fork check on first handshake to allow for the block not to be found. Also allow for block not to be found on sync check in case LIB moves during sync check.

Merges release/1.0-beta4 into main including #466

Resolves #456

@heifner heifner requested review from greg7mdp and linh2931 August 2, 2024 18:53
@heifner heifner added the OCI Work exclusive to OCI team label Aug 2, 2024
@heifner heifner merged commit d952b77 into main Aug 2, 2024
36 checks passed
@heifner heifner deleted the GH-456-fork-check-main branch August 2, 2024 20:05
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: INTERNALS
summary: More robust syncing to handle unavailable blocks, when client does not have backing blocklog.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

beta4 testnet - finalizer not voting
4 participants