Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace final_on_strong_qc_block_num in finality digest with other needed data #397

Merged
merged 8 commits into from
Jul 25, 2024
Merged

Replace final_on_strong_qc_block_num in finality digest with other needed data #397

merged 8 commits into from
Jul 25, 2024

Conversation

linh2931
Copy link
Member

Remove final_on_strong_qc_block_num from finality_digest_data_v1.

Then add the following into level_3_commitments:

  • latest_qc_claim_block_num
  • latest_qc_claim_finality_digest
  • latest_qc_claim_timestamp
  • timestamp: This is the timestamp of the current block.

Also remove final_on_strong_qc_block_num from finality_data and instead add latest_qc_claim_block_num, latest_qc_claim_finality_digest, and latest_qc_claim_timestamp to finality_data.

Resolves #386

@linh2931 linh2931 marked this pull request as draft July 24, 2024 18:03
@linh2931 linh2931 changed the title Replace final on strong qc in finality digest with other needed data Replace final_on_strong_qc_block_num in finality digest with other needed data Jul 24, 2024
@systemzax systemzax added the consensus-protocol Change to the consensus protocol. Impacts light client validation. label Jul 24, 2024
Base automatically changed from 2_chains to main July 24, 2024 21:22
@linh2931 linh2931 marked this pull request as ready for review July 25, 2024 01:51
@linh2931 linh2931 merged commit 0838e3e into main Jul 25, 2024
36 checks passed
@linh2931 linh2931 deleted the replace_final_on_strong_qc_in_finality_digest branch July 25, 2024 14:13
@ericpassmore
Copy link
Contributor

ericpassmore commented Jul 30, 2024 •
edited
Loading

Note:start
group: STABILITY
category: INTERNALS
summary: Update finality digest adding level 3 commitments.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@heifner heifner heifner approved these changes

@systemzax systemzax systemzax approved these changes

Assignees
No one assigned
Labels
consensus-protocol Change to the consensus protocol. Impacts light client validation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace final_on_strong_qc_block_num in finality digest calculation and instead add other needed data
5 participants
@linh2931 @ericpassmore @greg7mdp @heifner @systemzax