Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant log output and prometheus metrics update during replay #1020

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Remove redundant log output and prometheus metrics update during replay #1020

merged 4 commits into from
Nov 8, 2024

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented Nov 7, 2024

Before the change:

info  2024-11-07T23:18:21.438 nodeos    controller.cpp:1725           replay_block_log     ] 500 of 4983
info  2024-11-07T23:18:21.552 nodeos    controller.cpp:3566           log_applied          ] Received block 733efdcdfaeda3e0... #1000 @ 2024-  11-07T22:42:35.500 signed by eosio [trxs: 0, lib: 999, net: 0, cpu: 100 us, elapsed: 74 us, applying time: 188 us, latency: 2146052 ms]
info  2024-11-07T23:18:21.552 nodeos    controller.cpp:1725           replay_block_log     ] 1000 of 4983
info  2024-11-07T23:18:21.667 nodeos    controller.cpp:1725           replay_block_log     ] 1500 of 4983
info  2024-11-07T23:18:21.781 nodeos    controller.cpp:3566           log_applied          ] Received block d9216020d5998767... #2000 @ 2024-  11-07T22:50:55.500 signed by eosio [trxs: 0, lib: 1999, net: 0, cpu: 100 us, elapsed: 73 us, applying time: 188 us, latency: 1646281 ms]
info  2024-11-07T23:18:21.781 nodeos    controller.cpp:1725           replay_block_log     ] 2000 of 4983
info  2024-11-07T23:18:21.896 nodeos    controller.cpp:1725           replay_block_log     ] 2500 of 4983
info  2024-11-07T23:18:22.011 nodeos    controller.cpp:3566           log_applied          ] Received block 4cea00b8b37f995d... #3000 @ 2024-  11-07T22:59:15.500 signed by eosio [trxs: 0, lib: 2999, net: 0, cpu: 100 us, elapsed: 74 us, applying time: 188 us, latency: 1146511 ms]
info  2024-11-07T23:18:22.011 nodeos    controller.cpp:1725           replay_block_log     ] 3000 of 4983

After the change

info  2024-11-07T23:31:03.069 nodeos    controller.cpp:1725           replay_block_log     ] 500 of 5227
info  2024-11-07T23:31:03.182 nodeos    controller.cpp:1725           replay_block_log     ] 1000 of 5227
info  2024-11-07T23:31:03.295 nodeos    controller.cpp:1725           replay_block_log     ] 1500 of 5227
info  2024-11-07T23:31:03.408 nodeos    controller.cpp:1725           replay_block_log     ] 2000 of 5227
info  2024-11-07T23:31:03.521 nodeos    controller.cpp:1725           replay_block_log     ] 2500 of 5227
info  2024-11-07T23:31:03.634 nodeos    controller.cpp:1725           replay_block_log     ] 3000 of 5227

Resolves #1017

heifner
heifner requested changes Nov 8, 2024
View reviewed changes
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
@linh2931 linh2931 changed the title Remove redundant log output during replay Remove redundant log output and prometheus metrics update during replay Nov 8, 2024
@linh2931 linh2931 merged commit f871bf2 into main Nov 8, 2024
36 checks passed
@linh2931 linh2931 deleted the remove_log_applied branch November 8, 2024 14:19
@ericpassmore
Copy link
Contributor

Note:start
category: Logging
component: Internal
summary: Clean up redundant log and metrics output during replay.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heifner heifner heifner approved these changes

@spoonincode spoonincode spoonincode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spring 1.0 adds redundant information in log output during replay
4 participants
@linh2931 @ericpassmore @heifner @spoonincode