Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal footer buttons not spaced when using href in button #29658

Closed
1 task done
tqwewe opened this issue Mar 8, 2021 · 1 comment · Fixed by #29681
Closed
1 task done

Modal footer buttons not spaced when using href in button #29658

tqwewe opened this issue Mar 8, 2021 · 1 comment · Fixed by #29681
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@tqwewe
Copy link

tqwewe commented Mar 8, 2021

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Edit on CodeSandbox

Steps to reproduce

Create a modal with two custom action buttons.
Add a href to the second button.

footer={[
  <Button key="back" onClick={this.handleCancel}>
    Return
  </Button>,
  <Button
    key="submit"
    href="google.com" // <- This breaks the spacing
    type="primary"
    loading={loading}
    onClick={this.handleOk}
  >
    Submit
  </Button>
]}

What is expected?

The same spacing between the action buttons when not using a href.

What is actually happening?

There is no space between the buttons when using a href.

Environment Info
antd 4.13.1
React 17.0.1
System Mac OS BigSur
Browser Google Chrome - Version 88.0.4324.192 (Official Build) (x86_64)
@afc163 afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Mar 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2021

Hello @acidic9. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @acidic9,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

giphy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants