Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TypeScript peer dependency #50

Closed
krokofant opened this issue Mar 4, 2019 · 2 comments
Closed

Update TypeScript peer dependency #50

krokofant opened this issue Mar 4, 2019 · 2 comments

Comments

@krokofant
Copy link

The current stable 7.x release of NgZorro uses TypeScript "~3.2.2" while the angular-icons uses "~3.1.3".

Could these be synced up so that npm won't warn about mismatching peer dependencies?
@wzhudev
Copy link
Collaborator

wzhudev commented Mar 4, 2019 •
edited
Loading

@krokofant angular-icons uses TypeScript@3.1.3 mostly because I use Windows and TypeScript@3.2.2 breaks on Windows! 🤣 See: microsoft/TypeScript#29221

I think this wouldn't break anything, currently?

@krokofant
Copy link
Author

krokofant commented Mar 4, 2019 •
edited
Loading

@wendzhue Thanks for the note. The updated TypeScript version is what broke our build while upgrading ant 😄 I'm sure it's fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@krokofant @wzhudev