Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS dependent issues when combining docformatter and this hook #96

Open
RobPasMue opened this issue Nov 17, 2023 · 3 comments
Open

OS dependent issues when combining docformatter and this hook #96

RobPasMue opened this issue Nov 17, 2023 · 3 comments
Assignees
@klmcadams

Comments

@RobPasMue
Copy link
Member

Observed in https://github.com/ansys/pyansys-geometry and https://github.com/ansys/pyadditive

When running on Windows both hooks combined, no issues rise. However, docformatter on Linux detects that no extra line is needed in between module docstring and license header. And then our hook adds it back again.

I think there shouldn't be an extra line but please try to solve this behavior.
@RobPasMue
Copy link
Member Author

IMO...

License header should be right next to module docstring

#
# HEADER
# 
""" Docstring """

@RobPasMue
Copy link
Member Author

Did you have a chance to look into this @klmcadams?

@klmcadams
Copy link
Contributor

@RobPasMue I'm still looking into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@klmcadams klmcadams

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RobPasMue @klmcadams