Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to using 'docker' instead of 'docker-py' pip module #1303

Closed
samiam opened this issue May 17, 2018 · 3 comments
Closed

Port to using 'docker' instead of 'docker-py' pip module #1303

samiam opened this issue May 17, 2018 · 3 comments

Comments

@samiam
Copy link
Contributor

samiam commented May 17, 2018

Issue Type

  • Feature request

Molecule and Ansible details

ansible 2.5.2
molecule.pex, version 2.13.1

Molecule installation method (one of):

  • pip

Ansible installation method (one of):

  • pip

Desired Behavior

http://molecule.readthedocs.io/en/latest/configuration.html#docker

The docker module docs seem to imply you have to install 'docker-py' in order for molecule to work.

'docker-py' is deprecated and has been replaced by the 'docker' pip module.

I was wondering what porting effort is required to drop 'docker-py' and use 'docker' instead?

I use molecule in a pex bundle with ansible, molecule, etc. I would prefer to include 'docker' instead of 'docker-py' in the pex bundle.

Thoughts?

@retr0h
Copy link
Contributor

retr0h commented May 17, 2018

Molecule doesn't have any docker code. It simply uses the Ansible docker modules. Basically, if it works with Ansible's docker container it will work with Molecule. Ansible appears to require docker-py.

@tbondarchuk
Copy link
Contributor

There used to be strict dependency on docker-py, I think, but now ansible works just fine with docker, at least version 2.5. Guess docs just haven't been updated yet.

I remember reading some GitHub issue about ansible's docker support, but wasn't able to find it again.

Found this one instead, though:

You can have either docker or docker-py installed to use our modules. docker is preferred at this point.

However, you cannot have both python libraries installed at the same time.

ansible/ansible#22993

@retr0h
Copy link
Contributor

retr0h commented May 17, 2018

Closing as not related to Molecule at this time.

@retr0h retr0h closed this as completed May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants