Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missed button save when select webhook credential #7892

Closed
Kiviby opened this issue Aug 12, 2020 · 7 comments
Closed

missed button save when select webhook credential #7892

Kiviby opened this issue Aug 12, 2020 · 7 comments

Comments

@Kiviby
Copy link

Kiviby commented Aug 12, 2020

ISSUE TYPE
  • Bug Report
SUMMARY

when setting up a new webhook and selecting a credential there is no way to confirm the credential selection

ENVIRONMENT
  • AWX version: 14.0.0
  • AWX install method: docker on linux
  • Ansible version: 2.9.11
  • Operating System: RHEL 7.8
  • Web Browser: Chrome, Firefox
STEPS TO REPRODUCE

create new gitlab personal access token credential
configure job template to use webhook.
attempt to select previously created credential in the webhook credential field

EXPECTED RESULTS

select button visible to select the credential

ACTUAL RESULTS

list of credentials displayed with no way to select the credential

ADDITIONAL INFORMATION

missed_save

@jakemcdermott
Copy link
Contributor

jakemcdermott commented Aug 12, 2020

most likely related to latest version bump of jquery & other dependencies. See fixes for similar issues: #7553

@Kiviby
Copy link
Author

Kiviby commented Aug 12, 2020

in awx 13.0.0. same problem #7441

@jakemcdermott
Copy link
Contributor

jakemcdermott commented Aug 12, 2020

Note to anyone who works on this: removing any self-closing tags found in the following code will probably fix this bug so try that first:

workflow-add.controller.js#L129-L158
workflow-edit.controller.js#L168-L197
job-template-add.controller.js#L111-L140
job-template-edit.controller.js#L161-L189

See #7553 for example of fixes for similar issues

@tobgen
Copy link

tobgen commented Oct 3, 2020

Version 14.1.0 and 15.0.0 is affected by this as well.

@DejfCold
Copy link

DejfCold commented Oct 3, 2020

@tobgen The change was merged the day (1 oct) after the tag was created (30 sept) - #8304

@unlikelyzero
Copy link

PIpelines are borked due to galaxy. Will test next week

@unlikelyzero
Copy link

Covered in job-template-operations.spec.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants