Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically update templates list based on websocket messages #6622

Closed
mabashian opened this issue Apr 6, 2020 · 1 comment
Closed

Dynamically update templates list based on websocket messages #6622

mabashian opened this issue Apr 6, 2020 · 1 comment
Assignees
Labels
type:feature prioritized on a feature board

Comments

@mabashian
Copy link
Member

ISSUE TYPE
  • Feature Idea
SUMMARY

Socket behavior has changed in the old app - we should make it match up here. Use #5968 (comment) as a reference for expected behavior.

We'll need to subscribe to the jobs -> status_changed channel to get these updates.

When we get a message:

  • For new jobs (status = pending) we should try to find the template it belongs to and add this new job to the front of the recent_jobs array (popping the last job off if length > 10). For all other status updates we should try to find the template+job and update the status/finished timestamp. No GET requests needed.

Blocked until #5957, #5958 land

@dsesami
Copy link
Contributor

dsesami commented Jul 21, 2020

This is closed with the merge of #7613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature prioritized on a feature board
Projects
None yet
Development

No branches or pull requests

5 participants