Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annotations not applied to postgres statefulset #1624

Open
3 tasks done
pmcenery-bl opened this issue Nov 8, 2023 · 2 comments
Open
3 tasks done

annotations not applied to postgres statefulset #1624

pmcenery-bl opened this issue Nov 8, 2023 · 2 comments
Labels
community good first issue Good for newcomers help wanted Extra attention is needed type:enhancement New feature or request

Comments

@pmcenery-bl
Copy link

Please confirm the following

  • I agree to follow this project's code of conduct.
  • I have checked the current issues for duplicates.
  • I understand that the AWX Operator is open source software provided for free and that I might not receive a timely response.

Bug Summary

I have set the following:

AWX:
  spec:
    annotations: |
      eks.amazonaws.com/compute-type: ec2

They don't get applied, and checking the template manifests, it doesn't look like any annotations will reach the created resource.

It should be possible to set annotations on the postgres deployment, either via the global annotations or a new separate postgres_annotations possibly.

AWX Operator version

2.7.2

AWX version

2.7.2

Kubernetes platform

kubernetes

Kubernetes/Platform version

1.27

Modifications

no

Steps to reproduce

  1. Define annotations
  2. Apply
  3. Check statefulset annotations

Expected results

Global annotations should apply to deployments and statefulsets.

Actual results

No annotations flow through to the postgres statefulset.

Additional information

No response

Operator Logs

No response

@fosterseth fosterseth added help wanted Extra attention is needed good first issue Good for newcomers type:enhancement New feature or request labels Nov 8, 2023
@fosterseth
Copy link
Member

this would be a great contribution if someone from the community wants to implement it

a new separate postgres_annotations is preferable

@pmcenery-bl would you be interested?

@YaronL16
Copy link
Contributor

this was solved by PR #1829, right? Can we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community good first issue Good for newcomers help wanted Extra attention is needed type:enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants