Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event correlation code in awx_display callback #1321

Open
sivel opened this issue Oct 18, 2023 · 0 comments
Open

Fix event correlation code in awx_display callback #1321

sivel opened this issue Oct 18, 2023 · 0 comments

Comments

@sivel
Copy link
Member

sivel commented Oct 18, 2023

This will partially depend on ansible/ansible#81900

The current code is fragile, and isn't correlating correctly at the moment. Everything related to Display is classified as verbose, and many events are missing.

As the current implementation is fragile, because the code is attempting to infer things from core, it is likely best if we can find a way to implement the functionality in core, and then consume that instead. This will make a dependency between the core version and runner, so we may want to see if we can patch up the current implementation for backwards compat, and move the instantiation (monkey patching) into a function that can be used as needed.

@github-actions github-actions bot added the needs_triage New item that needs to be triaged label Oct 18, 2023
@sivel sivel removed the needs_triage New item that needs to be triaged label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant