Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #156/2d3c65e2 backport][stable-1] Fix deprecations for plugins and role entrypoints #158

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jun 9, 2023

This is a backport of PR #156 as merged into main (2d3c65e).

  • Fix indent of 'Why' and 'Alternative' texts for deprecations. If these texts happen to be multiple lines long, the other lines must be indented.
  • Allow role entrypoint deprecations without explicitly specifying removed_from_collection (which is the collection the role is part of anyway).

* Fix indent of 'Why' and 'Alternative' texts.

* Add tests.

* Allow role entrypoint deprecations without having to specify the collection the role is removed from.

* Fix YAML.

* Fix typo.

Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com>

---------

Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com>
(cherry picked from commit 2d3c65e)
@felixfontein felixfontein merged commit 966b769 into stable-1 Jun 9, 2023
@felixfontein felixfontein deleted the patchback/backports/stable-1/2d3c65e2d3d5af7bd5e9c6af41b3007c6f7161c5/pr-156 branch June 9, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant