From 9c57186f5647b37359390fca700f0ed0644cea6a Mon Sep 17 00:00:00 2001 From: irozet12 <119814380+irozet12@users.noreply.github.com> Date: Mon, 10 Jul 2023 13:41:51 +0300 Subject: [PATCH 1/3] Fix key error for reverse zone (#6905) --- plugins/modules/ipa_dnszone.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/plugins/modules/ipa_dnszone.py b/plugins/modules/ipa_dnszone.py index 06c93841ea2..6699b0525b8 100644 --- a/plugins/modules/ipa_dnszone.py +++ b/plugins/modules/ipa_dnszone.py @@ -152,7 +152,8 @@ def ensure(module, client): changed = True if not module.check_mode: client.dnszone_add(zone_name=zone_name, details={'idnsallowdynupdate': dynamicupdate, 'idnsallowsyncptr': allowsyncptr}) - elif ipa_dnszone['idnsallowdynupdate'][0] != str(dynamicupdate).upper() or ipa_dnszone['idnsallowsyncptr'][0] != str(allowsyncptr).upper(): + elif ipa_dnszone['idnsallowdynupdate'][0] != str(dynamicupdate).upper() or \ + ipa_dnszone.get('idnsallowsyncptr') and ipa_dnszone['idnsallowsyncptr'][0] != str(allowsyncptr).upper(): changed = True if not module.check_mode: client.dnszone_mod(zone_name=zone_name, details={'idnsallowdynupdate': dynamicupdate, 'idnsallowsyncptr': allowsyncptr}) From e0255061c6c4e611f492c803a9fb3d1390b2de19 Mon Sep 17 00:00:00 2001 From: irozet12 <119814380+irozet12@users.noreply.github.com> Date: Thu, 13 Jul 2023 17:34:25 +0300 Subject: [PATCH 2/3] Add changelog fragment for #6905 --- changelogs/fragments/6905-ipa_dnszone-key-error-fix.yml | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 changelogs/fragments/6905-ipa_dnszone-key-error-fix.yml diff --git a/changelogs/fragments/6905-ipa_dnszone-key-error-fix.yml b/changelogs/fragments/6905-ipa_dnszone-key-error-fix.yml new file mode 100644 index 00000000000..e0d2102fd74 --- /dev/null +++ b/changelogs/fragments/6905-ipa_dnszone-key-error-fix.yml @@ -0,0 +1,2 @@ +bugfixes: + - ipa_dnszone module - fix 'idnsallowsyncptr' key error for reverse zone (https://github.com/ansible-collections/community.general/pull/6906, https://github.com/ansible-collections/community.general/issues/6905). From 2c03a6f59ca151010306bf9ab79f40138178ed1d Mon Sep 17 00:00:00 2001 From: irozet12 <119814380+irozet12@users.noreply.github.com> Date: Sat, 15 Jul 2023 02:47:51 +0300 Subject: [PATCH 3/3] Fix changelog (6905) Co-authored-by: Felix Fontein --- changelogs/fragments/6905-ipa_dnszone-key-error-fix.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changelogs/fragments/6905-ipa_dnszone-key-error-fix.yml b/changelogs/fragments/6905-ipa_dnszone-key-error-fix.yml index e0d2102fd74..d7ce19d8b90 100644 --- a/changelogs/fragments/6905-ipa_dnszone-key-error-fix.yml +++ b/changelogs/fragments/6905-ipa_dnszone-key-error-fix.yml @@ -1,2 +1,2 @@ bugfixes: - - ipa_dnszone module - fix 'idnsallowsyncptr' key error for reverse zone (https://github.com/ansible-collections/community.general/pull/6906, https://github.com/ansible-collections/community.general/issues/6905). + - ipa_dnszone - fix 'idnsallowsyncptr' key error for reverse zone (https://github.com/ansible-collections/community.general/pull/6906, https://github.com/ansible-collections/community.general/issues/6905).