Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry callback plugin: remove code for Python <3.7 #9454

Closed
1 task done
russoz opened this issue Dec 29, 2024 · 2 comments · Fixed by #9482
Closed
1 task done

opentelemetry callback plugin: remove code for Python <3.7 #9454

russoz opened this issue Dec 29, 2024 · 2 comments · Fixed by #9482
Labels
callback callback plugin feature This issue/PR relates to a feature request plugins plugin (any type)

Comments

@russoz
Copy link
Collaborator

russoz commented Dec 29, 2024

Summary

Looking into the code, it seems to go through hops to ensure it has a time function with nanoseconds:

https://github.com/ansible-collections/community.general/blob/main/plugins/callback/opentelemetry.py#L167-L189

However, the bare minimum Python version for the controller (where the callback runs) is 3.8, which could simplify the code immensely.

Issue Type

Feature Idea

Component Name

plugins/callback/opentelemetry.py

Additional Information

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@ansibullbot
Copy link
Collaborator

Files identified in the description:

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link
Collaborator

cc @v1v
click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
callback callback plugin feature This issue/PR relates to a feature request plugins plugin (any type)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants