Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tags to be supplied to proxmox_lxc #5471

Closed
1 task done
GuillaumeV-cemea opened this issue Nov 4, 2022 · 4 comments · Fixed by #5714
Closed
1 task done

Allow tags to be supplied to proxmox_lxc #5471

GuillaumeV-cemea opened this issue Nov 4, 2022 · 4 comments · Fixed by #5714
Labels
cloud feature This issue/PR relates to a feature request has_pr module module plugins plugin (any type)

Comments

@GuillaumeV-cemea
Copy link
Contributor

Summary

Tags have been added to proxmox_qemu (see #1989) ; at the time, there was a bug with LXC tags.

From what I can tell, the bug has been fixed on proxmox 7 - I don't have a proxmox 6 node to test, but it should be fixed too (at least according to proxmox developer on the forum). So I think we can finally add tags to LXC :)

Looking at the MR(#2000), the code change seems straightforward, so I can provide a PR if needed

Cheers,

Issue Type

Feature Idea

Component Name

proxmox module

Additional Information

No response

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@ansibullbot
Copy link
Collaborator

Files identified in the description:

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added cloud feature This issue/PR relates to a feature request module module plugins plugin (any type) labels Nov 4, 2022
@russoz
Copy link
Collaborator

russoz commented Nov 6, 2022

hi @GuillaumeV-cemea thanks for reporting this request. A PR would be very welcome, and we would be happy to review it.

@GuillaumeV-cemea
Copy link
Contributor Author

Sorry for the delay, but I created a PR (#5714) for this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cloud feature This issue/PR relates to a feature request has_pr module module plugins plugin (any type)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants