From c77aa5067cdf5154e08865b3b1aa9b3e17f432a4 Mon Sep 17 00:00:00 2001 From: Felix Fontein Date: Sun, 29 Jan 2023 17:30:31 +0100 Subject: [PATCH] Extend tests a bit more. --- .../module_utils/test_dnspython_records.py | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/tests/unit/plugins/module_utils/test_dnspython_records.py b/tests/unit/plugins/module_utils/test_dnspython_records.py index a94f34f7..aa5808fa 100644 --- a/tests/unit/plugins/module_utils/test_dnspython_records.py +++ b/tests/unit/plugins/module_utils/test_dnspython_records.py @@ -12,6 +12,7 @@ import pytest from ansible_collections.community.dns.plugins.module_utils.dnspython_records import ( + RDTYPE_TO_FIELDS, convert_rdata_to_dict, ) @@ -38,6 +39,14 @@ 'address': '1:2::3', }, ), + ( + dns.rdata.from_text(dns.rdataclass.IN, dns.rdatatype.AAAA, '::'), + False, + True, + { + 'address': '::', + }, + ), ( dns.rdata.from_text(dns.rdataclass.IN, dns.rdatatype.CAA, '10 issue letsencrypt.org'), True, @@ -388,3 +397,12 @@ def test_convert_rdata_to_dict(rdata, to_unicode, add_synthetic, expected_result print(expected_result) print(result) assert expected_result == result + + +def test_error(): + v = RDTYPE_TO_FIELDS.pop(dns.rdatatype.A) + with pytest.raises(ValueError) as exc: + convert_rdata_to_dict(dns.rdata.from_text(dns.rdataclass.IN, dns.rdatatype.A, '3.3.3.3')) + RDTYPE_TO_FIELDS[dns.rdatatype.A] = v + print(exc.value.args) + assert exc.value.args == ('Unsupported record type 1', )