Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elements added dynamically after first run of br bolding are not bollded #92

Closed
asieduernest12 opened this issue May 29, 2022 · 3 comments · Fixed by #107
Closed

elements added dynamically after first run of br bolding are not bollded #92

asieduernest12 opened this issue May 29, 2022 · 3 comments · Fixed by #107
Assignees
@asieduernest12
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@asieduernest12
Copy link
Collaborator

This can be fixed with an observer on the document that runs the boldening script when new elements are added to the page

register the observer when body.br-bold is present
remove the observer when body.br-bold is removed
@asieduernest12 asieduernest12 self-assigned this May 29, 2022
@asieduernest12
Copy link
Collaborator Author

#8

@asieduernest12 asieduernest12 added the enhancement New feature or request label May 29, 2022
@ansh
Copy link
Owner

ansh commented May 29, 2022

Ah this is the problem with any website with infinite scroll right? So Twitter.com is probably a big issue.

@ansh ansh added the help wanted Extra attention is needed label May 29, 2022
@asieduernest12
Copy link
Collaborator Author

yup any website that basically adds new elements using js, so technically also sites built with vue, angular, react

@asieduernest12 asieduernest12 mentioned this issue Jun 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asieduernest12 asieduernest12

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat bolden newly added text nodes on dynamic sites automatically asieduernest12/jiffyreader.com
2 participants
@ansh @asieduernest12