Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Spellcheck on Document Deletion #948

Open
terencesimms opened this issue Feb 9, 2022 · 2 comments
Open

Remove Spellcheck on Document Deletion #948

terencesimms opened this issue Feb 9, 2022 · 2 comments
Labels
bug good first issue Easy issue for new contributors

Comments

@terencesimms
Copy link
Contributor

What is the issue?

When removing documents, CI fails due to a spellcheck running on the deleted files;

Steps To Reproduce

  • Delete a directory/document
  • Merge
  • Should fail with spellcheck errors

If applicable, add screenshots to help explain the problem.

image

eg. #947

Expected behaviour

Spellcheck should just ignored upon file deletion

@Xiol
Copy link
Contributor

Xiol commented Feb 9, 2022

Suspect this can be fixed by adjusting the files we get in the workflow. On L19 we're using steps.changed_files.outputs.all, but looking at the docs for that action, we should be using a mix of added, modified, renamed, and added_modified (as all includes removed).

@Xiol Xiol added the good first issue Easy issue for new contributors label Feb 9, 2022
@miff2000
Copy link
Contributor

@Xiol's comments do make this a nice one for someone to learn using. Reckon you might have someone up for doing it @terencesimms?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Easy issue for new contributors
Development

No branches or pull requests

3 participants