Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we wait for the RPC server to start in all e2e tests, before making any client calls #867

Closed
james-chf opened this issue Dec 6, 2022 · 3 comments
Labels

Comments

@james-chf
Copy link
Contributor

In many of our e2e tests, we wait for the ledger node to start up by looking for a string like below:

    validator_0.exp_string("Anoma ledger node started")?;

We often want to make client calls straight after (e.g. namadac tx), these require that the RPC server has started up, which we can check by awaiting for this string:

    validator_0.exp_string("Starting RPC HTTP server on")?;

Sometimes tests can flake locally as the client call is made before the RPC server is started. We should ensure we await the RPC server to be started in any tests where that is required - we could factor out a helper function to do this, which would also reduce code duplication.

@sug0
Copy link
Contributor

sug0 commented Dec 21, 2022

Related to #644

@james-chf
Copy link
Contributor Author

The string "Starting RPC HTTP server on" doesn't seem to be present on main branch, only eth-bridge-integration, so we could port it back

@cwgoes
Copy link
Contributor

cwgoes commented May 25, 2023

Seems to be fixed.

@cwgoes cwgoes closed this as completed May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Tested in Devnet
Development

No branches or pull requests

3 participants