Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commission rate transition to PoS VP state machine test #769

Closed
Tracked by #2006
brentstone opened this issue Nov 10, 2022 · 3 comments
Closed
Tracked by #2006

Add commission rate transition to PoS VP state machine test #769

brentstone opened this issue Nov 10, 2022 · 3 comments
Assignees
Labels
PoS post-mainnet Don't worry about this yet.
Milestone

Comments

@brentstone
Copy link
Collaborator

brentstone commented Nov 10, 2022

From a thread of comments on #695:

We can however add a Transition for ValidPosAction::ChangeCommissionRate, for which the model would need to have a pre-condition that ensures that the new rate is less than or equal to the validator's max_commission_rate_change with respect to its last epoch's rate. I think this can be done in in the abstract SM by e.g. looking through self.all_valid_actions().into_iter().rev() for the last rate value (either from a previous ValidPosAction::ChangeCommissionRate or ValidPosAction::InitValidator if it's not been changed before) before the last epoch switch. However, the epoch switch is currently not preserved in the abstract state machine - we only have the current epoch, so we might need to change that first.

Originally posted by @tzemanovic in #695 (comment)

@cwgoes
Copy link
Contributor

cwgoes commented Jan 14, 2023

@brentstone Is this still applicable?

@brentstone
Copy link
Collaborator Author

@brentstone Is this still applicable?

Yes, this ultimately wasn't covered in #695 and should still be done.

@cwgoes cwgoes added this to the 0.15 milestone Jan 16, 2023
@brentstone brentstone added the post-mainnet Don't worry about this yet. label Feb 13, 2024
@cwgoes
Copy link
Contributor

cwgoes commented Aug 29, 2024

Does not apply anymore.

@cwgoes cwgoes closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PoS post-mainnet Don't worry about this yet.
Projects
None yet
Development

No branches or pull requests

2 participants