Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify MASP validity flag #2684

Closed
Tracked by #2530 ...
grarco opened this issue Feb 21, 2024 · 0 comments · Fixed by #2790
Closed
Tracked by #2530 ...

Modify MASP validity flag #2684

grarco opened this issue Feb 21, 2024 · 0 comments · Fixed by #2790
Labels
MASP pre-mainnet Must happen before mainnet. validity-predicate

Comments

@grarco
Copy link
Collaborator

grarco commented Feb 21, 2024

Currently, we identify masp vp for the clients based on the fact that the masp vp was triggered and the tx was successful. This means that the MASP vp has to reject any transaction that triggers it but doesn't touch any masp keys because, if the tx also carried a valid Transaction object, this could trick clients into fetching and evaluating this tx.

We should add another condition to the previous two: the fact that at least one masp key was changed by the transaction. By doing this we could modify the MASP vp to accept txs that didn't touch any masp key and ensure that the clients' state won't be corrupted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MASP pre-mainnet Must happen before mainnet. validity-predicate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants