Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix check on nullifiers #2594

Closed
Tracked by #2530
, #2843
...
grarco opened this issue Feb 12, 2024 · 0 comments · Fixed by #2621
Closed
Tracked by #2530
, #2843
...

Fix check on nullifiers #2594

grarco opened this issue Feb 12, 2024 · 0 comments · Fixed by #2621
Assignees
@grarco
Labels
bug Something isn't working MASP pre-mainnet Must happen before mainnet. security validity-predicate
Milestone
Phase 3: activate...

Comments

@grarco
Copy link
Collaborator

grarco commented Feb 12, 2024

Currently the masp VP verifies the nullifiers only if source == MASP. This means that a shielding transaction could write arbitrary nullifiers and still be accepted. We should instead do this check all the times, regardless of the source of the transaction.
@grarco grarco self-assigned this Feb 12, 2024
@grarco grarco mentioned this issue Feb 12, 2024
Closed
37 tasks
@grarco grarco added the pre-mainnet Must happen before mainnet. label Feb 12, 2024
@grarco grarco mentioned this issue Feb 15, 2024
Merged
2 tasks
@cwgoes cwgoes mentioned this issue Mar 7, 2024
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grarco grarco

Labels
bug Something isn't working MASP pre-mainnet Must happen before mainnet. security validity-predicate
Projects
None yet
Milestone
Phase 3: activate IBC and shielded pool
Development

Successfully merging a pull request may close this issue.

Fix nullifiers check anoma/namada
2 participants
@brentstone @grarco