Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init-network should be able to optionally bundle wasm files along with the network config files #2423

Closed
Tracked by #2792
sug0 opened this issue Jan 22, 2024 · 4 comments · Fixed by #3196
Closed
Tracked by #2792
Assignees
Labels

Comments

@sug0
Copy link
Collaborator

sug0 commented Jan 22, 2024

Currently, init-network generates a ${chain_id}.tar.gz file containing network config toml files and a wasm checksums json file. It should also (optionally) contain the wasm files pointed to by the checksums file.

@cwgoes
Copy link
Collaborator

cwgoes commented Apr 24, 2024

Most importantly, we should check the WASM hashes against the expected ones when starting the node.

@cwgoes
Copy link
Collaborator

cwgoes commented Apr 24, 2024

#3119 is sufficient for the time being.

@Fraccaman
Copy link
Member

Fraccaman commented Apr 24, 2024

shouldn't we include the wasms in the chain tar.gz? and remove the download functionality from the ledger? Otherwise we have to host infrastructure

@cwgoes
Copy link
Collaborator

cwgoes commented Apr 24, 2024

shouldn't we include the wasms in the chain tar.gz? and remove the download functionality from the ledger? Otherwise we have to host infrastructure

I don't think so, we can just upload the WASMs to a separate repository on GitHub and use the raw download URLs?

Maybe that's more difficult than including the WASMs in .tar.gz though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants