Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pruning BridgePool Merkle tree #2264

Closed
wants to merge 2 commits into from
Closed

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Dec 11, 2023

Describe your changes

When a signed nonce wasn't stored, the pruning failed.
To fix it, it skips when there is no signed root.

Indicate on which release or other PRs this topic is based on

0.28.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@yito88 yito88 requested review from Fraccaman and sug0 December 11, 2023 20:26
@yito88 yito88 marked this pull request as ready for review December 11, 2023 20:45
Copy link
Collaborator

@sug0 sug0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks!

Fraccaman pushed a commit that referenced this pull request Dec 13, 2023
* origin/yuji/fix-bp-tree-pruning:
  add changelog
  fix pruning bp merkle tree
Fraccaman pushed a commit that referenced this pull request Dec 13, 2023
* origin/yuji/fix-bp-tree-pruning:
  add changelog
  fix pruning bp merkle tree
@Fraccaman Fraccaman mentioned this pull request Dec 13, 2023
brentstone pushed a commit that referenced this pull request Dec 13, 2023
* origin/yuji/fix-bp-tree-pruning:
  add changelog
  fix pruning bp merkle tree
@Fraccaman Fraccaman closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants