Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use secp256k1 keys for eth keys #1967

Open
Tracked by #2006
, #2023
...
tzemanovic opened this issue Oct 4, 2023 · 0 comments
Open
Tracked by #2006
, #2023
...

use secp256k1 keys for eth keys #1967

tzemanovic opened this issue Oct 4, 2023 · 0 comments
Labels
ethereum-bridge PoS post-mainnet Don't worry about this yet. prio:low

Comments

@tzemanovic
Copy link
Member

We're currently using common::Public/SecretKey for eth keys which permits ed25519, but they can only be secp256k1. We storing these in PoS epoched type (ValidatorEthHotKeys, ValidatorEthColdKeys). When we change these, we can replace conversion to EthAddress with EthAddressConvError::CannotBeEd25519 error to an infallible one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ethereum-bridge PoS post-mainnet Don't worry about this yet. prio:low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tzemanovic