Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Governance ETH bridge vote #1166

Closed
grarco opened this issue Feb 17, 2023 · 0 comments
Closed

Governance ETH bridge vote #1166

grarco opened this issue Feb 17, 2023 · 0 comments
Assignees
@Fraccaman @grarco
Labels
ethereum-bridge ledger validity-predicate

Comments

@grarco
Copy link
Collaborator

grarco commented Feb 17, 2023 •
edited
Loading

Depends on #133.

The current implementation of the governance vp is missing a proper validation for ETH bridge-related votes.
Also, the required action must be performed in finalize_block
@grarco grarco self-assigned this Feb 17, 2023
@grarco grarco mentioned this issue Feb 17, 2023
Merged
@grarco grarco changed the title Governance ETH bridge vote validation Governance ETH bridge vote Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fraccaman Fraccaman

@grarco grarco

Labels
ethereum-bridge ledger validity-predicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fraccaman @grarco