refactor(cxl-ui): close drawer by default on mobile #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
lkraav
reviewed
Nov 3, 2021
| super.updated(changedProperties); | ||
|
|
||
| if (changedProperties.has('wide') && !this.wide) { | ||
| this.asideOpened = false; |
There was a problem hiding this comment.
Do we need to still keep track of what the state was on wide, so it returns to such, when toggling between mobile / desktop.
There was a problem hiding this comment.
Updated to restore drawer state on media change
lkraav
reviewed
Nov 3, 2021
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Are we able to do a much simpler ${this.wide && this.asideOpened} conditional upgrade directly on <aside> element template?
There was a problem hiding this comment.
I just tried that. Since wide would always evaluate to false on mobile the drawer doesn't open.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.