Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vaadin-tabs[theme=cxl-tabs-slider] #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

vaadin-tabs[theme=cxl-tabs-slider] #10

wants to merge 1 commit into from

Conversation

anoblet
Copy link
Owner

@anoblet anoblet commented Apr 26, 2021

No description provided.

@anoblet
Copy link
Owner Author

anoblet commented Apr 28, 2021

@lkraav

Would you be able to elaborate on Main <article> element has type definition class, etc. and Elemente structure should follow prior art and Hybrid conventions - no new inventions on class names is necessary.?

I'm unsure of how to accomplish the hybrid conventions in this context. Since these are testimonials, the data from theme=cxl-archive.data.json doesn't map.

@anoblet anoblet mentioned this pull request Apr 28, 2021
Closed
lkraav
lkraav requested changes Apr 29, 2021
View reviewed changes
@anoblet anoblet force-pushed the cxl-tabs-slider branch 2 times, most recently from a6d67ef to e675e5d Compare May 5, 2021 00:33
@anoblet anoblet force-pushed the cxl-tabs-slider branch from e675e5d to 31334d1 Compare May 5, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkraav lkraav lkraav requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anoblet @lkraav