Skip to content

Zoomed in image becomes blurry on iOS if 'will-change' is applied #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Oleksandr-Dubiv opened this issue Aug 3, 2024 · 1 comment

Comments

@Oleksandr-Dubiv
Copy link

Oleksandr-Dubiv commented Aug 3, 2024

Hi! Nice plugin!

Couple of stuff to notice:

  • seems like max\min feature is not in Master branch (still on a separate branch) and seems working
  • my main problem now is that after modifications in max\min branch for optimization reasons you gave added elem.style['will-change'] = 'transform';. thought it triggers 3D transformations handled by GPU, unfortunately this also means that Safari is as always sucks... It makes image unusable blurry thus eliminating sense of zooming in. Reason: when 'will-change' is applied browser makes 'screenshot' that is later zoomed in and that not the original hi-res image ;( If I remove this line - everything goes back to sharp but yeah, on slower devices you can notice some freezes when manipulating image. Some other plugins tackle this image by auto-overlaying one more 2d-transformed image (PinchZoom.js) but this also creates irritating blurriness changes even on each pan (not only zoom).

Any ideas how to preserve both 'will-change' and sharpness in more optimal way? Thanks

@anitasv
Copy link
Owner

anitasv commented Aug 3, 2024

Thank you for this, I haven’t checked these across devices which is why it is not merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants