issue#17 create navbar sub-menu #37
Conversation
mtreacy002
added
Category: Coding
|
Update @anitab-org/bridgeintech-maintainers and @meenakshi-dhanani. I've ecompleted the Navbar sub-menu tasks. Can you please reeview? In the meantime I'll work on the View /user/personal_details page. Thanks |
src/Routes.js
Outdated
| path="/my-space" | ||
| > | ||
| <MySpace /> | ||
| exact path="/my-portfolio"> |
There was a problem hiding this comment.
can't we just say /portfolio /profile ? this my my doesn't sound right
There was a problem hiding this comment.
Updated. I've removed My. Now it's only Portfolio/Profile
src/myspace/MyPortfolio.jsx
Outdated
| @@ -0,0 +1,21 @@ | |||
| import React from "react"; | |||
|
|
|||
| export default function MyPortfolio() { | |||
There was a problem hiding this comment.
Again I just find My My in everything unnecessary.
src/Navigation.js
Outdated
| </Navbar.Brand> | ||
| <Navbar.Toggle aria-controls="basic-navbar-nav" /> | ||
| <Navbar.Collapse id="basic-navbar-nav"> | ||
|
|
There was a problem hiding this comment.
why so many lines?
There was a problem hiding this comment.
sorry, I missed that. It's fixed now.
src/Navigation.js
Outdated
| </Card> | ||
| </Accordion> | ||
| </Nav.Item> | ||
|
|
There was a problem hiding this comment.
why so many lines
src/Navigation.js
Outdated
| <Nav.Link as={Link} to="/profile">Profile</Nav.Link> | ||
| <Nav.Link as={Link} to="/request-history">Request History</Nav.Link> | ||
| </Nav> | ||
|
|
There was a problem hiding this comment.
there is a closing tag and indentation. why so many lines?
src/Navigation.js
Outdated
| <Accordion> | ||
| <Card> | ||
| <Card.Header> | ||
| <Accordion.Toggle as={Link} to="my-portfolio" eventKey="0">My Space</Accordion.Toggle> |
There was a problem hiding this comment.
are there two routes now? /portfolio and /my-portfolio?
There was a problem hiding this comment.
nop. that's a bug. I've fixed it now. Thanks for pointing that out, @meenakshi-dhanani 😁
|
Update @meenakshi-dhanani . I've just pushed the requested changes. Can you please re-review? Thanks |
|
@foongminwong can you approve again? |
Description
Add sub-menu so user can navigate to member's private pages under
My SpaceFixes #17
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
Checked that all functionalities that have been done so far work as expected.
Checklist:
Code/Quality Assurance Only