Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA: Add travis file for testing #25

Merged
merged 2 commits into from
Jun 21, 2020
Merged

QA: Add travis file for testing #25

merged 2 commits into from
Jun 21, 2020

Conversation

mtreacy002
Copy link
Member

Description

Added travis file

Fixes #12 and replaces PR #22

Type of Change:

  • Code
  • Quality Assurance

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

pushing to local fork and travis resulted in passed build

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings

@mtreacy002 mtreacy002 mentioned this pull request Jun 20, 2020
Closed
4 tasks
@mtreacy002 mtreacy002 changed the title added travis file QA: Add travis file for testing Jun 20, 2020
@mtreacy002
Copy link
Member Author

mtreacy002 commented Jun 20, 2020 •
edited
Loading

Update @anitab-org/bridgeintech-maintainers . This PR is now ready to be (re)-review. Thanks cc @foongminwong and @meenakshi-dhanani

@mtreacy002 mtreacy002 requested a review from a team June 20, 2020 01:44
@mtreacy002 mtreacy002 self-assigned this Jun 20, 2020
@mtreacy002 mtreacy002 added Category: Quality Assurance Changes to code or files that improve testing or fixes bugs. Program: GSOC Related to work completed during the Google Summer of Code Program. labels Jun 20, 2020
@mtreacy002 mtreacy002 added this to the GSoC: Coding Phase I milestone Jun 20, 2020
meenakshi-dhanani
meenakshi-dhanani approved these changes Jun 20, 2020
View reviewed changes
Copy link
Contributor

@meenakshi-dhanani meenakshi-dhanani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup looks good

@meenakshi-dhanani
Copy link
Contributor

@anitab-org/bridgeintech-maintainers can someone approve? We've been waiting on a pending approval for a while now

@foongminwong foongminwong self-requested a review June 21, 2020 13:14
@foongminwong foongminwong merged commit 82c4093 into anitab-org:develop Jun 21, 2020
@mtreacy002 mtreacy002 deleted the issue12-add-travis-ci-to-frontend branch June 27, 2020 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meenakshi-dhanani meenakshi-dhanani meenakshi-dhanani approved these changes

@foongminwong foongminwong foongminwong approved these changes

Assignees

@mtreacy002 mtreacy002

Labels
Category: Quality Assurance Changes to code or files that improve testing or fixes bugs. Program: GSOC Related to work completed during the Google Summer of Code Program.
Projects
None yet
Milestone
GSoC: Coding Phase I
Development

Successfully merging this pull request may close these issues.

Setup Travis CI to run tests for BIT React frontend
3 participants
@mtreacy002 @meenakshi-dhanani @foongminwong