Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue12 add travis ci to frontend #22

Conversation

mtreacy002
Copy link
Member

@mtreacy002 mtreacy002 commented Jun 15, 2020

Description

This PR is to add travis CI and test cases for Register user functionality.

Fixes #12

Type of Change:

  • Code
  • Quality Assurance

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)

Additional Note

  • Travis CI is added before writing test cases. Failed result is expected.

@mtreacy002 mtreacy002 requested a review from a team June 16, 2020 00:40
@mtreacy002 mtreacy002 self-assigned this Jun 16, 2020
@mtreacy002 mtreacy002 added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Program: GSOC Related to work completed during the Google Summer of Code Program. labels Jun 16, 2020
@mtreacy002 mtreacy002 added this to the GSoC: Coding Phase I milestone Jun 16, 2020
@meenakshi-dhanani
Copy link
Contributor

Why are there changes to other files besides travis.yml in this PR? I would expect a few test cases and travis.yml change here only, not the other files

@mtreacy002
Copy link
Member Author

mtreacy002 commented Jun 18, 2020

Sorry, posted the comment on a wrong PR. 🤣

@mtreacy002
Copy link
Member Author

@meenakshi-dhanani, you will see this a lot during GSoC. Don't be alarmed and thinking I did unnecessary changes 🤣. When I created this PR, the changes to my Register UI hasn't been merged to develop branch, so when I pushed, it still has the original boilerplate from the create-react-app. You can see it from the commit history.

Screen Shot 2020-06-19 at 9 15 37 am

@mtreacy002
Copy link
Member Author

mtreacy002 commented Jun 18, 2020

And I created the PR branch out of the develop branch at the time (which was already contains the boilerplate) which is I believe the correct way to do (not branching out of Register UI PR branch). Plus, this was OK (not branching out from other working PR) since I don't need any other code related to travis. Different case when I branched out from Basic setup code to Register UI code that needs the basic setup code to work on. Hope this makes sense.

@mtreacy002
Copy link
Member Author

Ok, I removed the boilerplate files now. Can you please review this now, @meenakshi-dhanani ?

@mtreacy002
Copy link
Member Author

@anitab-org/bridgeintech-maintainers and @meenakshi-dhanani . Atm travis is failing since there is no tests found in the PR (I haven't written one yet and have deleted the boilerplate including the App.js and App.test.js as suggested). Will you be able to merge this as it is or do you want me to write one Register test case on the same PR here?

@meenakshi-dhanani
Copy link
Contributor

Okay I can see the build is passing for the test case. I have some feedback on the test case, but that I will discuss in the test case PR.

Screen Shot 2020-06-19 at 9 26 50 PM

@meenakshi-dhanani
Copy link
Contributor

@foongminwong can you approve if all seems fine?

@mtreacy002
Copy link
Member Author

Okay I can see the build is passing for the test case. I have some feedback on the test case, but that I will discuss in the test case PR.

Screen Shot 2020-06-19 at 9 26 50 PM

Yeah, I've fixed it and gave update on zulip. just forgot to give update here. ;P

@mtreacy002
Copy link
Member Author

@anitab-org/bridgeintech-maintainers . I'll need to do some clean up on this PR git branch so it won't carry unnecessary files to develop branch. So @meenakshi-dhanani and @foongminwong , please review it again after my cleanup.

@mtreacy002 mtreacy002 closed this Jun 20, 2020
@mtreacy002 mtreacy002 force-pushed the issue12-add-travis-ci-to-frontend branch from b68d5ea to b5bf859 Compare June 20, 2020 01:10
@mtreacy002 mtreacy002 mentioned this pull request Jun 20, 2020
3 tasks
@mtreacy002
Copy link
Member Author

Update @anitab-org/bridgeintech-maintainers . I have cleaned up my PR branch. I'm closing this PR and replace it with PR #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Program: GSOC Related to work completed during the Google Summer of Code Program.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup Travis CI to run tests for BIT React frontend
2 participants