-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue12 add travis ci to frontend #22
Issue12 add travis ci to frontend #22
Conversation
Why are there changes to other files besides travis.yml in this PR? I would expect a few test cases and travis.yml change here only, not the other files |
Sorry, posted the comment on a wrong PR. 🤣 |
@meenakshi-dhanani, you will see this a lot during GSoC. Don't be alarmed and thinking I did unnecessary changes 🤣. When I created this PR, the changes to my Register UI hasn't been merged to develop branch, so when I pushed, it still has the original boilerplate from the create-react-app. You can see it from the commit history. |
And I created the PR branch out of the develop branch at the time (which was already contains the boilerplate) which is I believe the correct way to do (not branching out of Register UI PR branch). Plus, this was OK (not branching out from other working PR) since I don't need any other code related to travis. Different case when I branched out from Basic setup code to Register UI code that needs the basic setup code to work on. Hope this makes sense. |
Ok, I removed the boilerplate files now. Can you please review this now, @meenakshi-dhanani ? |
@anitab-org/bridgeintech-maintainers and @meenakshi-dhanani . Atm travis is failing since there is no tests found in the PR (I haven't written one yet and have deleted the boilerplate including the App.js and App.test.js as suggested). Will you be able to merge this as it is or do you want me to write one Register test case on the same PR here? |
@foongminwong can you approve if all seems fine? |
Yeah, I've fixed it and gave update on zulip. just forgot to give update here. ;P |
@anitab-org/bridgeintech-maintainers . I'll need to do some clean up on this PR git branch so it won't carry unnecessary files to develop branch. So @meenakshi-dhanani and @foongminwong , please review it again after my cleanup. |
b68d5ea
to
b5bf859
Compare
Update @anitab-org/bridgeintech-maintainers . I have cleaned up my PR branch. I'm closing this PR and replace it with PR #25 |
Description
This PR is to add travis CI and test cases for Register user functionality.
Fixes #12
Type of Change:
Checklist:
Code/Quality Assurance Only
Additional Note