Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#16 Remove .vscode #21

Merged
merged 2 commits into from
Jun 15, 2020
Merged

Conversation

mahakbansal2019
Copy link
Contributor

@mahakbansal2019 mahakbansal2019 commented Jun 14, 2020

Description

Remove .vscode

Fixes #16

Type of Change:

  • Code

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings

@mahakbansal2019
Copy link
Contributor Author

@mtreacy002 Could you please review this.
Thanks :)

@mtreacy002
Copy link
Member

mtreacy002 commented Jun 15, 2020

This looks good to me, @mahakbansal2019 . Thanks for contributing. We just need to wait for one more reviewer to approve this PR before we can merge it 😉

@mtreacy002
Copy link
Member

mtreacy002 commented Jun 15, 2020

By the way, @mahakbansal2019, did you see my notes on issue #19? I need t move it across to backend since I mistakenly placed it in frontend. If you are still interested, here's the link for the same isse (issue#55) on backend.

@mtreacy002 mtreacy002 added the Category: Coding Changes to code base or refactored code that doesn't fix a bug. label Jun 15, 2020
mtreacy002
mtreacy002 previously approved these changes Jun 15, 2020
Copy link
Member

@mtreacy002 mtreacy002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, @mahakbansal2019 . Thanks for contributing. 😁

@mtreacy002 mtreacy002 requested a review from a team June 15, 2020 05:18
@mtreacy002
Copy link
Member

By the way, @mahakbansal2019 , can you please use the format available on the repository for this? Contributors are required to use the given template for consistency across the project. You can copy paste the template on to this PR description above to adopt the correct format. You can find the template for the PR here

@mtreacy002
Copy link
Member

I'm yet to update the frontend Wiki to match its backend repo. so, the mistake is mine that you didn't use the PR template. But if you could update it by modifying the PR description here, I would really appreciate your help 👍

@mtreacy002
Copy link
Member

mtreacy002 commented Jun 15, 2020

Just a question, @mahakbansal2019 . when you open the Pull Request, did it come with a template? It should have come automatically.

If so, please fill up the template where it is required. And please do not remove the subheadings so to maintain consistency across AnitaB projects. It will be a good learning experience for you to bring across different open source projects in the future 😄

@mahakbansal2019
Copy link
Contributor Author

@mtreacy002 Sorry for not following the correct template.
I have updated the description.
Hope it's fine now :)
Will do the required updates if needed :)

@mtreacy002
Copy link
Member

Perfect.... It looks much better now (more descriptive in terms of explaining the purpose of the PR). Thank you for the update, @mahakbansal2019

@meenakshi-dhanani
Copy link
Contributor

meenakshi-dhanani commented Jun 15, 2020

You will also have to delete the .vscode directory that is already committed. .gitignore will ensure henceforth it doesn't get committed. But for the already committed one, can you delete it?

@mahakbansal2019
Copy link
Contributor Author

I have deleted the .vscode directory.
Thanks, @meenakshi-dhanani for the review :)

@mahakbansal2019 mahakbansal2019 requested review from mtreacy002 and removed request for a team June 15, 2020 10:59
Copy link
Contributor

@meenakshi-dhanani meenakshi-dhanani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mahakbansal2019 ! Looks good to me. Thank you so much for contributing.
Since you have picked up a first timer issue, for the other issues, it would be nice if you involve the other community members :) That's also a way to contribute. And a very fulfilling one 😄

@meenakshi-dhanani
Copy link
Contributor

@mtreacy002 Feel free to merge if it looks good

@mtreacy002
Copy link
Member

mtreacy002 commented Jun 15, 2020

Thanks, @meenakshi-dhanani . But I think only @anitab-org/bridgeintech-maintainers can merge a PR. The merge button is disabled on my side since I'm not authorised to merge 😁
Screen Shot 2020-06-16 at 12 29 16 am

@meenakshi-dhanani
Copy link
Contributor

But I think you can approve, I can do the merging if necessary

Copy link
Member

@mtreacy002 mtreacy002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @mahakbansal2019 👍 .

@meenakshi-dhanani meenakshi-dhanani merged commit 8595f1f into anitab-org:develop Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove .vscode
3 participants