-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix#16 Remove .vscode #21
Conversation
@mtreacy002 Could you please review this. |
This looks good to me, @mahakbansal2019 . Thanks for contributing. We just need to wait for one more reviewer to approve this PR before we can merge it 😉 |
By the way, @mahakbansal2019, did you see my notes on issue #19? I need t move it across to backend since I mistakenly placed it in frontend. If you are still interested, here's the link for the same isse (issue#55) on backend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, @mahakbansal2019 . Thanks for contributing. 😁
By the way, @mahakbansal2019 , can you please use the format available on the repository for this? Contributors are required to use the given template for consistency across the project. You can copy paste the template on to this PR description above to adopt the correct format. You can find the template for the PR here |
I'm yet to update the frontend Wiki to match its backend repo. so, the mistake is mine that you didn't use the PR template. But if you could update it by modifying the PR description here, I would really appreciate your help 👍 |
Just a question, @mahakbansal2019 . when you open the Pull Request, did it come with a template? It should have come automatically. If so, please fill up the template where it is required. And please do not remove the subheadings so to maintain consistency across AnitaB projects. It will be a good learning experience for you to bring across different open source projects in the future 😄 |
@mtreacy002 Sorry for not following the correct template. |
Perfect.... It looks much better now (more descriptive in terms of explaining the purpose of the PR). Thank you for the update, @mahakbansal2019 |
You will also have to delete the .vscode directory that is already committed. .gitignore will ensure henceforth it doesn't get committed. But for the already committed one, can you delete it? |
I have deleted the .vscode directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mahakbansal2019 ! Looks good to me. Thank you so much for contributing.
Since you have picked up a first timer issue, for the other issues, it would be nice if you involve the other community members :) That's also a way to contribute. And a very fulfilling one 😄
@mtreacy002 Feel free to merge if it looks good |
Thanks, @meenakshi-dhanani . But I think only @anitab-org/bridgeintech-maintainers can merge a PR. The merge button is disabled on my side since I'm not authorised to merge 😁 |
But I think you can approve, I can do the merging if necessary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @mahakbansal2019 👍 .
Description
Remove .vscode
Fixes #16
Type of Change:
Code/Quality Assurance Only
Checklist:
Code/Quality Assurance Only