Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Repository base setup #9

Closed
4 of 5 tasks
meenakshi-dhanani opened this issue May 31, 2020 · 4 comments · Fixed by #10
Closed
4 of 5 tasks

UI Repository base setup #9

meenakshi-dhanani opened this issue May 31, 2020 · 4 comments · Fixed by #10
Assignees
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Program: GSOC Related to work completed during the Google Summer of Code Program.

Comments

@meenakshi-dhanani
Copy link
Contributor

meenakshi-dhanani commented May 31, 2020

Description

Have a setup working with all dependencies and required directory structure.

Acceptance Criteria

  • create a base setup for a react app
  • add dependencies for testing
  • you should be able to build and run your app

Definition of Done

  • All of the required items are completed.
  • Approval by 2 mentor.

Estimation

1 day

@meenakshi-dhanani meenakshi-dhanani added the Category: Coding Changes to code base or refactored code that doesn't fix a bug. label May 31, 2020
@meenakshi-dhanani meenakshi-dhanani added the Program: GSOC Related to work completed during the Google Summer of Code Program. label May 31, 2020
@mtreacy002
Copy link
Member

@meenakshi-dhanani. Just wanna check.
So, I've created the basic setup for react using create-react-app boilerplate and merge it with the existing files/folder from the bridge-in-tech-web. The react app run successfully. Would this suffice for this issue? If so, I'll open the PR and push the code changes.

Screen Shot 2020-06-02 at 7 31 10 pm

@meenakshi-dhanani
Copy link
Contributor Author

Replace the default page with a default page for your app. Maybe have Bridge-in-tech and some 1-2 line description and that should be enough :)

@mtreacy002
Copy link
Member

Ok 👍 will work on it..

@mtreacy002 mtreacy002 self-assigned this Jun 4, 2020
@meenakshi-dhanani
Copy link
Contributor Author

All looks good. Except this directory called js(Not a really meaningful name) and it has just one file so again it doesn't need to be extracted into a directory. In future when you have multiple related files, choose to move them to related directories.

My suggestion: Put Home.jsx back to the src directory. Remove js directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Program: GSOC Related to work completed during the Google Summer of Code Program.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants