-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue#86 PUT /user/personal_background api endpoint and tests #87
Issue#86 PUT /user/personal_background api endpoint and tests #87
Conversation
Update @anitab-org/bridgeintech-maintainers . Here's the PR for PUT /user/personal_background api endpoint and tests. please provide feedback whenever you're available. Thanks |
fe3dba7
to
598bd04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I like the very detailed docstrings, makes the review and understanding much easier for me!
thank you @ramitsawhney27 for your kind feedback. |
598bd04
to
0ecf6a9
Compare
Update @anitab-org/bridgeintech-maintainers . I've modified the background enum logic on backend as discussed in the last BIT weekly meeting. Please re-review once you have time. Thanks |
0ecf6a9
to
09217fa
Compare
Update @anitab-org/bridgeintech-maintainers . I've just force pushed changes to add other fields for physical and mental ability as well as socio-economic status |
09217fa
to
432933c
Compare
Update @anitab-org/bridgeintech-maintainers . I'vee resolved the mergee conflicts and applied bug fixes discussed on zulip post and issue #94 (temporary solution for local environment only). |
432933c
to
0e1fb7e
Compare
Update @anitab-org/bridgeintech-maintainers . I've refactor this PR to use only one API endpoint PUT /user/personal_background for both create and update user personal background information. Please review when you have time. |
5ca9e20
to
8164dcb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes made in this PR were tested locally. Following are the results:
-
Code review - Done
-
All possible responses were tested as below:
-
Test PR 87 (Create non-existing personal background)
Screenshot/gif/url:Expected Result: As a user, I should be able to create personal background using
PUT /user/personal_background
Actual Result: -
Test PR 87 (Update existing personal background)
Screenshot/gif/url:Expected Result: As a user, I should be able to update existing personal background using
PUT /user/personal_background
Actual Result: Same as expected
-
-
OS Version: Windows 10
-
Tested JSON:
{
"gender": "Prefer not to say",
"age": "Prefer not to say",
"ethnicity": "Prefer not to say",
"sexual_orientation": "Prefer not to say",
"religion": "Prefer not to say",
"physical_ability": "Prefer not to say",
"mental_ability": "Prefer not to say",
"socio_economic": "Prefer not to say",
"highest_education": "Prefer not to say",
"years_of_experience": "Prefer not to say",
"gender_other": "Prefer not to say",
"ethnicity_other": "Prefer not to say",
"sexual_orientation_other": "Prefer not to say",
"religion_other": "Prefer not to say",
"physical_ability_other": "Prefer not to say",
"mental_ability_other": "Prefer not to say",
"socio_economic_other": "Prefer not to say",
"highest_education_other": "Prefer not to say",
"is_public": true
}
Fix bug on testing fix typo requests.put mock patch Remove POST user/personal_background Remove Create personal background dao
…ints Refactored Background enum logic Refactor test to include other fields for physical, mental ability and socio economic Remove POST api endpoint for create user personal background Remove Create personal background dao
Refactored background enum logic for update personal background Add other fields for physical, mental ability and socio economic Fix: bug on user_id not retrieved error message and setting Refactor POST PUT update personal background to one api endpoint PUT
8164dcb
to
8b14e21
Compare
Update @anitab-org/bridgeintech-maintainers . I've just resolved the merge conflict on this PR. Please re-approve and only merge this PR after the PR #85 which is this PR's blocker is merged to develop. Thanks |
Description
Allow user to update their personal background data
Fixes #86
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
Checklist:
Code/Quality Assurance Only