Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds environment setup instructions #56

Merged
merged 2 commits into from
Jun 17, 2020

Conversation

mahakbansal2019
Copy link
Contributor

@mahakbansal2019 mahakbansal2019 commented Jun 15, 2020

Description

Add link to environment setup instructions in README.md

Fixes #55

Type of Change:

  • Documentation

Code/Quality Assurance Only

  • This change requires a documentation update (software upgrade on readme file)

Checklist:

  • My PR follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

Copy link
Member

@mtreacy002 mtreacy002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mahakbansal2019, can you please place it as descriptive link just like everywhere else in the document (example here is in Contributing section).

You can add it as a new section in between Contributing and Branches.

Screen Shot 2020-06-16 at 8 19 17 am

@mtreacy002
Copy link
Member

mtreacy002 commented Jun 16, 2020

@Menina294 and @mahakbansal2019, I should've labelled this issue a First timer only since this is a very simple task. But, that's ok since @mahakbansal2019 already pushed the PR and I've requested a change.

@mahakbansal2019
Copy link
Contributor Author

@mtreacy002
How about this ?
Screenshot from 2020-06-16 09-31-57

README.md Outdated
@@ -11,6 +11,10 @@ This is the backend client of Bridge-In-Tech.

Please read our [Contributing Guidelines](.github/CONTRIBUTING.md), [Code of Conduct](.github/CODE_OF_CONDUCT.md) and [Reporting Guidelines](.github/REPORTING_GUIDELINES.md) thoroughly.

**BridgeInTech Environment Setup Instructions**

https://github.com/anitab-org/bridge-in-tech-backend/wiki/BIT-development-environment-setup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good that you have now placed it in a separate section @mahakbansal2019. However, instead of showing it as http url, can you mask it with a descriptive link (like the one in Contributing section) perhaps say something like...
"To start contributing to the project, setup the backend environment on your local machine by following the instructions on the BIT Development Environment Setup Instruction wiki page"
(on the bold words you can place that url link to wiki). Does this make sense?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay!
Will make the desired changes :)

@@ -11,6 +11,9 @@ This is the backend client of Bridge-In-Tech.

Please read our [Contributing Guidelines](.github/CONTRIBUTING.md), [Code of Conduct](.github/CODE_OF_CONDUCT.md) and [Reporting Guidelines](.github/REPORTING_GUIDELINES.md) thoroughly.

## Setup
To start contributing to the project, setup the backend environment on your local machine by following the instructions on the [BIT Development Environment Setup Instruction]( https://github.com/anitab-org/bridge-in-tech-backend/wiki/BIT-development-environment-setup) wiki page.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now, @mahakbansal2019. I'm happy to approve this. We just need to wait for one more reviewer to approve the PR before it can be merged. cc @anitab-org/coding-team or @anitab-org/bridgeintech-maintainers .

Thanks again for your contribution and patience in responding to each requested changes 😉

Copy link
Member

@mtreacy002 mtreacy002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@foongminwong foongminwong self-requested a review June 17, 2020 01:25
Copy link

@foongminwong foongminwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well 👍

@foongminwong foongminwong merged commit adda8a6 into anitab-org:develop Jun 17, 2020
mtreacy002 pushed a commit to mtreacy002/bridge-in-tech-backend that referenced this pull request Jun 23, 2020
* Added environment setup instructions
* Added a descriptive link
mtreacy002 pushed a commit to mtreacy002/bridge-in-tech-backend that referenced this pull request Jun 26, 2020
* Added environment setup instructions
* Added a descriptive link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc: Add link to Bridge In Tech Setup Instructions
3 participants