This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix(websocket): fix #824, patch websocket onproperties correctly in PhantomJS #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhevery
suggested changes
Jul 6, 2017
|
@mhevery , sure , I will add |
…ly in phantomjs
JiaLiPassion
force-pushed
the
issue-824
branch
2 times, most recently
from
4940e59
to
6da774d
Compare
|
@mhevery , I have added phantomjs test and added it to travis. I have confirmed without this PR, websocket test will fail in phantomjs test, please review. |
mhevery
approved these changes
Jul 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #824.
Patch websocket in phantomjs, from #768, we will check that the patch target's descriptor exists and is configurable. But for websocket, we create a
proxySocketfor some browsers which don't allow to override those properties. So we need to tellzone.jsthoseproxySocketis also ok to be patched.