This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix(showError): fix ignoreConsoleErrorUncaughtError may change during drain microtask #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix showError flag issue.
showError flag may change when drain microTask queue. So if we change the flag in one of the microTask, the flag will not be updated.
refactor parameter name in
promise.handleUnhandledRejectionrefactor showError, because we change the showError logic above, so maybe we provide
showUncaughtError()in ZonePrivate is better.@mhevery, please review that ZonePrivate API change is ok or not. Thank you!